BTW, I have noticed that we can't place kbUnitQuerySetUnitType before kbUnitQuerySetPlayerID, kbUnitQuerySetState, or it will forever return 0.

That's because you forgot to set reset to false.
kbUnitQuerySetPlayerID(queryID,playerID, bool reset)

That's because you forgot to set reset to false.
==> Thanks! I didn't know there's a bool.

EDIT:
How do you guys locate the incorrect lines? My script now wont run :/

[This message has been edited by ylg_hke (edited 10-18-2018 @ 02:54 AM).]

Locate incorrect lines: super large comment, then make it smaller and smaller until you see the incorrect line.

/*
Codes
Codes
Codes
Incorrect
Codes
Codes*/

Codes
Codes
/*
Codes
Incorrect
Codes
Codes*/

Codes
Codes
Codes
Incorrect
/*Codes
Codes*/


It's extremely annoying so just avoid incorrect lines as much as you can.

Are you running the debugger +noIntroCinematics +developer +aiDebug +showAIOutput +logAIErrors and then using the AI debug files in My Documents/.../AI3 to find the last line?

[This message has been edited by Panmaster2014 (edited 10-18-2018 @ 03:56 PM).]

super large comment, then make it smaller and smaller until you see the incorrect line.
==> This is exactly what I have been doing, haha.


debugger +noIntroCinematics +developer +aiDebug +showAIOutput +logAIErrors and then using the AI debug files
==> Oh cool, it shows the rule name, right? It would be best if it could show the exact line number.
Anyway it's a huge improvement already, Thanks!!

Where are you murdilator XD you started the thread XD

Where are you murdilator XD you started the thread XD
==> After so many years, he probably get bored with AI scripting...


Anyway, somehow the transport plan can't ungarrison villagers on my end, any idea? (I just copied it from ZenAI to an empty .xs file.)
=======================================

rule Trans
active
minInterval 5
{

aiSetWaterMap(true);
static int gGetMyUnitQueryID = -1;
if (gGetMyUnitQueryID < 0)
{ gGetMyUnitQueryID = kbUnitQueryCreate("gGetMyUnitQueryID"); }


static int buildID = -1;
if (buildID < 0)
{
kbUnitQueryResetResults(gGetMyUnitQueryID);
kbUnitQuerySetPlayerID(gGetMyUnitQueryID, cMyID);
kbUnitQuerySetState(gGetMyUnitQueryID, cUnitStateAlive);
kbUnitQuerySetUnitType(gGetMyUnitQueryID, cUnitTypeTownCenter);
kbUnitQueryExecute(gGetMyUnitQueryID);
buildID = kbUnitQueryGetResult(gGetMyUnitQueryID, 0);
}

kbUnitQueryResetResults(gGetMyUnitQueryID);
kbUnitQuerySetPlayerID(gGetMyUnitQueryID, cMyID);
kbUnitQuerySetState(gGetMyUnitQueryID, cUnitStateAlive);
kbUnitQuerySetUnitType(gGetMyUnitQueryID, cUnitTypeAbstractVillager);
int UnitNo = kbUnitQueryExecute(gGetMyUnitQueryID);

aiChat(1, "buildID " + buildID);
aiChat(1, "kbGetUnitBaseTypeID(buildID) " + kbGetUnitBaseTypeID(buildID));
aiChat(1, "UnitNo " + UnitNo);

if(UnitNo < 1)
{return;}

vector v = kbUnitGetPosition(buildID);
int UnitID = -1;
int planID = -1;
planID = aiPlanCreate("DeGarrison"+buildID,cPlanTransport);
aiPlanAddUnitType(planID,cUnitTypeAbstractVillager,1,99,99);
aiPlanSetVariableInt(planID,cTransportPlanTransportID,0,buildID);
aiPlanSetVariableInt(planID,cTransportPlanTransportTypeID,0,kbGetUnitBaseTypeID(buildID));
aiPlanSetVariableInt(planID,cTransportPlanPathType,0,cTransportPathTypePoints);
aiPlanSetVariableBool(planID,cTransportPlanTakeMoreUnits,0,false);
aiPlanSetVariableBool(planID,cTransportPlanPathPlanned,0,true);
aiPlanSetVariableBool(planID,cTransportPlanPersistent,0,false);
aiPlanSetVariableBool(planID,cTransportPlanReturnWhenDone,0,false); //no effect
aiPlanSetVariableBool(planID,cTransportPlanMaximizeXportMovement,0,false); //no effect
aiPlanSetVariableVector(planID,cTransportPlanGatherPoint,0, v);

aiPlanSetActive(planID,true);

for(i=0;<UnitNo)
{
UnitID = kbUnitQueryGetResult(gGetMyUnitQueryID, i);
aiPlanAddUnit(planID, UnitID);
}
}


=======================================

You're trying to put villagers inside villagers (buildid AbstractVillager). That's why it doesn't work.


Look at my Ceylon transport plan, in my script.

[This message has been edited by AlistairJah (edited 10-19-2018 @ 05:39 AM).]

buildid AbstractVillager
==> I don't get it:

kbUnitQueryResetResults(gGetMyUnitQueryID);
kbUnitQuerySetPlayerID(gGetMyUnitQueryID, cMyID);
kbUnitQuerySetState(gGetMyUnitQueryID, cUnitStateAlive);
kbUnitQuerySetUnitType(gGetMyUnitQueryID, cUnitTypeTownCenter);
kbUnitQueryExecute(gGetMyUnitQueryID);
buildID = kbUnitQueryGetResult(gGetMyUnitQueryID, 0);

buildID is a TC.

I had read your script, but yours is really for transport, not for ungarrision, that's why I copied from ZenAI.

Are you sure?

Quoted from ylg_hke:

kbUnitQueryResetResults(gGetMyUnitQueryID);
kbUnitQuerySetPlayerID(gGetMyUnitQueryID, cMyID);
kbUnitQuerySetState(gGetMyUnitQueryID, cUnitStateAlive);
kbUnitQuerySetUnitType(gGetMyUnitQueryID, cUnitTypeAbstractVillager);
int UnitNo = kbUnitQueryExecute(gGetMyUnitQueryID);

Are you sure?
==>

kbUnitQuerySetUnitType(gGetMyUnitQueryID, cUnitTypeAbstractVillager);
int UnitNo = kbUnitQueryExecute(gGetMyUnitQueryID);

wrong quotation, this's UnitNo, not buildID, please re-read my script, I run the query twice, first get tc id and then get all villager count.

Anyway, please forget that rule , i moved it to the original AI and replaced the query with getUnit and now its working.

I noticed that turning off aiSetRandomMap(true) seems to be another way to make transport plan works.

Oops my bad

Since Town Bell plan is often too slow to start and only affect nearby units, we need manual garrison anyway.

If you have time please test it, now villagers should be able to garrison at nearby TC outpost village castle fort:

====================================================
3 extern int
===================================================
extern int gGetMyUnitQueryID = -1;
extern int gGetAllyUnitQueryID = -1;
extern int gGetEnemyUnitQueryID = -1;
gGetMyUnitQueryID = kbUnitQueryCreate("gGetMyUnitQueryID");

gGetAllyUnitQueryID = kbUnitQueryCreate("gGetAllyUnitQueryID");

gGetEnemyUnitQueryID = kbUnitQueryCreate("gGetEnemyUnitQueryID");

------------ --------------- -----------




void GathererGetShelter(vector Position = cInvalidVector)
{
int GathererNo = -1;

kbUnitQueryResetResults(gGetMyUnitQueryID);
kbUnitQuerySetPlayerID(gGetMyUnitQueryID, cMyID);
kbUnitQuerySetState(gGetMyUnitQueryID, cUnitStateAlive);
kbUnitQuerySetUnitType(gGetMyUnitQueryID, cUnitTypeAbstractVillager);
kbUnitQuerySetPosition(gGetMyUnitQueryID, Position);
kbUnitQuerySetMaximumDistance(gGetMyUnitQueryID, 40);
kbUnitQuerySetAscendingSort(gGetMyUnitQueryID, true);
GathererNo = kbUnitQueryExecute(gGetMyUnitQueryID);

if(GathererNo < 1)
{
return;
}

int GathererID = -1;
int ShelterNo = -1;
int ShelterID = -1;
int ShelterType = -1;
int UngarrisonPlanID = -1;
int EffectiveCount = -1;

kbUnitQueryResetResults(gGetAllyUnitQueryID);
kbUnitQuerySetPlayerID(gGetAllyUnitQueryID, -1);
kbUnitQuerySetPlayerRelation(gGetAllyUnitQueryID, cPlayerRelationAlly);
kbUnitQuerySetState(gGetAllyUnitQueryID, cUnitStateAlive);
kbUnitQuerySetIgnoreKnockedOutUnits(gGetAllyUnitQueryID, true);
kbUnitQuerySetPosition(gGetAllyUnitQueryID, Position);
kbUnitQuerySetMaximumDistance(gGetAllyUnitQueryID, 120);
kbUnitQuerySetAscendingSort(gGetAllyUnitQueryID, true);

kbUnitQuerySetUnitType(gGetAllyUnitQueryID, cUnitTypeAbstractTownCenter);
ShelterNo = kbUnitQueryExecute(gGetAllyUnitQueryID);

kbUnitQuerySetUnitType(gGetAllyUnitQueryID, cUnitTypeAbstractFort);
ShelterNo = kbUnitQueryExecute(gGetAllyUnitQueryID);

kbUnitQuerySetUnitType(gGetAllyUnitQueryID, cUnitTypeAbstractFoundry);
ShelterNo = kbUnitQueryExecute(gGetAllyUnitQueryID);

for(x = 0; < ShelterNo)
{
ShelterID = kbUnitQueryGetResult(gGetAllyUnitQueryID, x);

if((kbUnitIsType(ShelterID, cUnitTypeVictoryPointBuilding) == true) || (kbUnitIsType(ShelterID, cUnitTypeArtilleryDepot) == true))
{
continue;
}

break;
}

UngarrisonPlanID = aiPlanCreate("Ungarrison" + ShelterID, cPlanTransport);
aiPlanSetVariableInt(UngarrisonPlanID, cTransportPlanTransportID, 0, ShelterID);
aiPlanSetVariableInt(UngarrisonPlanID, cTransportPlanTransportTypeID, 0, kbGetUnitBaseTypeID(ShelterID));
aiPlanSetVariableBool(UngarrisonPlanID, cTransportPlanPathPlanned, 0, true);
aiPlanSetVariableVector(UngarrisonPlanID, cTransportPlanGatherPoint, 0, kbUnitGetPosition(ShelterID));

EffectiveCount = 0;

for(x = 0; < GathererNo)
{
GathererID = kbUnitQueryGetResult(gGetAllyUnitQueryID, x);

if((kbUnitIsType(GathererID, cUnitTypeShip) == true) || (kbUnitGetPlanID(GathererID) >= 0))
{
continue;
}

EffectiveCount = EffectiveCount + 1;
aiTaskUnitWork(GathererID, ShelterID);
aiPlanAddUnit(UngarrisonPlanID, GathererID);
}

aiPlanAddUnitType(UngarrisonPlanID, cUnitTypeAbstractVillager, 1, EffectiveCount, EffectiveCount);

xsEnableRule("GathererUngarrison");
}


rule GathererUngarrison
inactive
minInterval 7
{
int UngarrisonPlanNo = -1;
int UngarrisonPlanID = -1;
int ShelterID = -1;
int EnemyNo = -1;
int EnemyHP = -1;
int AllyHP = -1;

UngarrisonPlanNo = aiPlanGetNumber(cPlanTransport, -1, false);

if(UngarrisonPlanNo == 0)
{
xsDisableSelf();
return;
}

for(x = 0; < UngarrisonPlanNo)
{
UngarrisonPlanID = aiPlanGetIDByIndex(cPlanTransport, -1, false, x);
ShelterID = aiPlanGetVariableInt(UngarrisonPlanID, cTransportPlanTransportID, 0);

if(kbUnitIsType(ShelterID, cUnitTypeShip) == true)
{
continue;
}

kbUnitQueryResetResults(gGetEnemyUnitQueryID);
kbUnitQuerySetPlayerID(gGetEnemyUnitQueryID, -1);
kbUnitQuerySetPlayerRelation(gGetEnemyUnitQueryID, cPlayerRelationEnemyNotGaia);
kbUnitQuerySetState(gGetEnemyUnitQueryID, cUnitStateAlive);
kbUnitQuerySetIgnoreKnockedOutUnits(gGetEnemyUnitQueryID, true);
kbUnitQuerySetPosition(gGetEnemyUnitQueryID, kbUnitGetPosition(ShelterID));
kbUnitQuerySetMaximumDistance(gGetEnemyUnitQueryID, 40);
kbUnitQuerySetAscendingSort(gGetEnemyUnitQueryID, true);
kbUnitQuerySetUnitType(gGetEnemyUnitQueryID, cUnitTypeLogicalTypeLandMilitary);
EnemyNo = kbUnitQueryExecute(gGetEnemyUnitQueryID);
EnemyHP = kbUnitQueryGetUnitHitpoints(gGetEnemyUnitQueryID, true);

if(EnemyNo < 1)
{
aiPlanSetActive(UngarrisonPlanID);
continue;
}

if(EnemyNo >= 10)
{
continue;
}

kbUnitQueryResetResults(gGetAllyUnitQueryID);
kbUnitQuerySetPlayerID(gGetAllyUnitQueryID, -1);
kbUnitQuerySetPlayerRelation(gGetAllyUnitQueryID, cPlayerRelationAlly);
kbUnitQuerySetState(gGetAllyUnitQueryID, cUnitStateAlive);
kbUnitQuerySetIgnoreKnockedOutUnits(gGetAllyUnitQueryID, true);
kbUnitQuerySetPosition(gGetAllyUnitQueryID, kbUnitGetPosition(ShelterID));
kbUnitQuerySetMaximumDistance(gGetAllyUnitQueryID, 40);
kbUnitQuerySetAscendingSort(gGetAllyUnitQueryID, true);
kbUnitQuerySetUnitType(gGetAllyUnitQueryID, cUnitTypeLogicalTypeLandMilitary);
kbUnitQueryExecute(gGetAllyUnitQueryID);
AllyHP = kbUnitQueryGetUnitHitpoints(gGetAllyUnitQueryID, true);

if(AllyHP >= (EnemyHP*2))
{
aiPlanSetActive(UngarrisonPlanID);
}
}
}



EDIT:
How can i change the scenario game speed to fast ?

[This message has been edited by ylg_hke (edited 10-20-2018 @ 09:41 PM).]

You can't change scenario speed.

I found this post:
http://aoe3.heavengames.com/cgi-bin/forums/display.cgi?action=ct&f=12,37493,,10
But sadly, map ("shift-g", "developer", "gameSpeedMult(2.0)") doesn't work, I think its another hidden function.


Anyway, suddenly many questions came to mind:
-what does kbEscrowSetCap do?

-Is "rule selectCaptain" useless? i dont seem to find anything else related to it.

-Any info about AttackPlanAttackRoutePattern, AttackPlanBaseAttackMode, AttackPlanRetreatMode ?

-Any progress on making unitPicker to respect the ratio?
Or may be we should just use our own train plans?



Regarding updateForecasts, now i think we should set a fixed amount of resource for calculating military budgets, consider the following facts:

train time:
villager = 25 (100f = 100)
musket = 30 (75f25g = 100)
xbow = 27 (40f40w = 80)
hussar = 40 (120f80g = 200)

in early age2, within 1 min, on average we will have (ABQ):
villager = 2.4 (1 tc) = 2.4*100 = 240
musket = 14-17 (2 barracks) = ~15*100 = 1500
xbow = 14-18 (2 barracks) = ~15*80 = 1200
hussar = 5-8 (1 stable) = ~6.5*200 = 1300

these ratios should be rather static and expend accordingly, so, may be something like this:
==============================
//1st land unit
CostFood = kbUnitCostPerResource(gPrimaryArmyUnit, cResourceFood);
CostWood = kbUnitCostPerResource(gPrimaryArmyUnit, cResourceWood);
CostGold = kbUnitCostPerResource(gPrimaryArmyUnit, cResourceGold);

CostTotal = CostFood + CostWood + CostGold;

EffectiveNo = (1350 * gPrimaryArmyUnitRatio) / CostTotal;

CostFood = CostFood * EffectiveNo;
CostWood = CostWood * EffectiveNo;
CostGold = CostGold * EffectiveNo;

PercentageFood = PercentageFood + CostFood;
PercentageWood = PercentageWood + CostWood;
PercentageGold = PercentageGold + CostGold;
==============================


BTW, have i ever mentioned that kbUnitQuery seems to be player based? mother-nature cant access player 1's queries, vice versa.

what does kbEscrowSetCap do?

It should limit the amount in escrow. It's still unknown if escrows can cause resource leakages.

Any info about AttackPlanAttackRoutePattern, AttackPlanBaseAttackMode, AttackPlanRetreatMode ?

I've run enough tests in the scenario editor to be certain the first and second do nothing whatsoever.

BTW, have i ever mentioned that kbUnitQuery seems to be player based? mother-nature cant access player 1's queries, vice versa.

You need to set the player context before creating the query. That would make sense given queries have the see-able option.

[This message has been edited by Panmaster2014 (edited 10-21-2018 @ 11:17 PM).]

Quoted from ylg_hke:

BTW, have i ever mentioned that kbUnitQuery seems to be player based? mother-nature cant access player 1's queries, vice versa.

Well, nearly all of knowledge base functions, if not all of them, are "player based" like you say. Query that's been executed as player 1 can't be seen by player 2.

I've run enough tests in the scenario editor to be certain the first and second do nothing whatsoever.
==>
What about AttackPlanRetreatMode?

I remember making troops not to take the straightforward path, but to take the near-map-edge path. It was like 2-3 months ago, and now I'm not sure how I did it....


Anyway, the bool of kbUnitQuerySetPlayerID is insanely important.
I know that I mentioned it and kbUnitQuerySetUnitType before, but seriously, we either have to set it to false
or have to place kbUnitQuerySetPlayerID right after kbUnitQueryResetResults, otherwise it will mess things up.

Even ES scripters overlooked it, "getUnit" from the original AI is flawed, it can get fallen hero units, even with kbUnitQuerySetIgnoreKnockedOutUnits = true.


BTW, alive, non-shrined huntables have at least 3 action types: 7 8 47

fallen hero action type = 43

What about AttackPlanRetreatMode?

I only use cAttackPlanRetreatModeNone. Given how stupid it is already retreating would do more harm than good.

I remember making troops not to take the straightforward path, but to take the near-map-edge path. It was like 2-3 months ago, and now I'm not sure how I did it....

The path is always the same. It always goes for the weakest point or nearest. At least it can group-move and path through walls.

BTW, alive, non-shrined huntables have at least 3 action types: 7 8 47

Actiontype 3 when shrined or penned.

Given how stupid it is already retreating would do more harm than good.
==> Inf are too slow but Cav should be able to get away (?)

Anyway, have anyone tried "No TrainPlan, forever aiTaskUnitTrain" for military units?


EDIT:
kbUnitGetMovementType is probably broken, it always returns 1.

[This message has been edited by ylg_hke (edited 10-25-2018 @ 11:06 AM).]

Anyway, have anyone tried "No TrainPlan, forever aiTaskUnitTrain" for military units?

Quicker and easier to use than plans but you lose out on aiGetCurrentResourceNeed() and escrows.

kbUnitGetMovementType is probably broken, it always returns 1.

Make sure you use the unitTypeID, not unitID.

There is resource leakage in escrows, confirmed. I can't seem to fix it, no matter what I try. Any idea?

[This message has been edited by AlistairJah (edited 10-26-2018 @ 11:30 AM).]

I still don't fully understand how kbResourceGet() can be more than all escrow amounts combined. kbEscrowAllocateResources resets it at least. If there's a leak somewhere it's not obvious, maybe wood seems low at times but it does get 60+ upgrades... hmm

Make sure you use the unitTypeID, not unitID.
<==Nailed it!

How did you guys identify the resource leakage in escrows?

Compare values returned by kbResourceGet() and kbEscrowGetAmount()

Any progress on escrows?

anyway, i just wanted to say that kbUnitQuerySetAreaGroupID is very important when it comes to maps like ceylon, Yucatan.